Skip to content

[FLINK-38838] Update spotless style version to AOSP 1.24.0 & reorganize CI modules#4211

Merged
yuxiqian merged 2 commits into
apache:masterfrom
yuxiqian:ci/reorganize-test-modules
Jan 8, 2026
Merged

[FLINK-38838] Update spotless style version to AOSP 1.24.0 & reorganize CI modules#4211
yuxiqian merged 2 commits into
apache:masterfrom
yuxiqian:ci/reorganize-test-modules

Conversation

@yuxiqian
Copy link
Copy Markdown
Member

@yuxiqian yuxiqian commented Jan 5, 2026

This PR combine some small modules together to reduce matrix size, as we may need to run tests against multiple Flink versions.

Modules are arbitrarily chosen to let each stage to finish in ~60 minutes.

Also closes FLINK-38838 by upgrading spotless plugin style version, since Java 17 tests are blocked by this.

@yuxiqian yuxiqian force-pushed the ci/reorganize-test-modules branch from bb23de8 to 64581ba Compare January 5, 2026 12:07
@yuxiqian
Copy link
Copy Markdown
Member Author

yuxiqian commented Jan 5, 2026

Hi @lvyanquan, please take a look when you have time.

@yuxiqian yuxiqian force-pushed the ci/reorganize-test-modules branch from 64581ba to bda36cc Compare January 6, 2026 04:07
@yuxiqian yuxiqian force-pushed the ci/reorganize-test-modules branch from bda36cc to cfa6fe8 Compare January 6, 2026 04:50
@leosanqing
Copy link
Copy Markdown

leosanqing commented Jan 8, 2026

I also occurred this Build error with jdk17

spotless:spotless-maven-plugin:2.43.0:check failed: You are running Spotless on JVM 17. This requires google-java-format of at least 1.10.0 (you are using 1.8).

@leosanqing
Copy link
Copy Markdown

leosanqing commented Jan 8, 2026

I also occurred this Build error with jdk17

spotless:spotless-maven-plugin:2.43.0:check failed: You are running Spotless on JVM 17. This requires google-java-format of at least 1.10.0 (you are using 1.8).

Maybe it's not necessary upgrade to 1.24.0, bump to 1.13.0(I tested,It's the highest version) won't change style.

lvyanquan
lvyanquan approved these changes Jan 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@lvyanquan lvyanquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.
Thanks @yuxiqian's contribution.

@yuxiqian
Copy link
Copy Markdown
Member Author

yuxiqian commented Jan 8, 2026

I also occurred this Build error with jdk17

spotless:spotless-maven-plugin:2.43.0:check failed: You are running Spotless on JVM 17. This requires google-java-format of at least 1.10.0 (you are using 1.8).

Maybe it's not necessary upgrade to 1.24.0, bump to 1.13.0(I tested,It's the highest version) won't change style.

Thank you for investigating this! I picked AOSP 1.24.0 as it's the code style that Flink main project uses.

@yuxiqian yuxiqian merged commit a40b870 into apache:master Jan 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lvyanquan lvyanquan lvyanquan approved these changes

Assignees

No one assigned

Labels

approved base build common db2-cdc-connector debezium elasticsearch-pipeline-connector maxcompute-pipeline-connector mongodb-cdc-connector mysql-cdc-connector oceanbase-pipeline-connector oracle-cdc-connector paimon-pipeline-connector postgres-cdc-connector reviewed runtime

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuxiqian @leosanqing @lvyanquan